-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Winit version 0.30.0 #3655
Winit version 0.30.0 #3655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a tad unfortunate that we loose git blame
info on this file, but it's probably not used very often anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was kind of broken even before when I was moving changelog entries around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it help if you did it in two commits, and then rebase merge the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter how it's done, because it's moved anyway.
Reading the changelog I wrote #3656, so that the new gestures support more than just two platforms. I’ve found that the unit of the rotation gesture isn’t specified, the Wayland protocol exposes it in degrees but I don’t know what Apple does, it would be useful to specify that before the release. |
The gestures are present for a very long time, like 2-3 years, it's just they were renamed a bit this release, so while specifying them is good, they were always meant for macOS only and the metrics are the same as in all other releases. |
Ah you’re right, they were already present in the previous release, but the unit is still unspecified in the documentation, so I still don’t know what it’s meant to be even on macOS. Or do you mean it’s a unit/event specific to macOS and shouldn’t be tried to be matched on other windowing systems? |
Just in case, so the correct changelog will be rendered when pulling the crate from the crates.io as archive and trying to build it.
Signed-off-by: growfrow <growfrow@outlook.com>
…3657) Setting the background color changes how the window title bar appears, which is something that the application should customize itself if it wants this behaviour (and also, it wasn't set when calling `set_transparent`, so the behaviour wasn't consistent).
The unit of rotation is documented in #3597 to be degrees. |
- Allow all gestures simultaneously recognized. - Add PanGestureRecogniser with min/max number of touches. - Fix sending delta values relative to Update instead to match macOS. - Fix rotation gesture units from iOS to be in degrees instead of radians. Co-authored-by: Mads Marquart <mads@marquart.dk>
5c67c7a
to
d7fd537
Compare
--
Should be fine after these:
ndk 0.9.0
andandroid-activity 0.6.0
#3653.cargo
config is not published #3654